@bbockelm commented on this pull request.


In src/XrdSys/XrdSysE2T.cc:

> @@ -55,7 +58,15 @@ int initErrTable()
 // Premap all known error codes.
 //
    for(int i = 1; i <errSlots; i++)
-      {eTxt = strerror(ERRNOBASE + i);
+      {// NOTE: On systems without EAUTH (authentication error; currently all systems but GNU Hurd),
+       // EAUTH is remapped to EBADE ('invalid exchange').  Given there's no current XRootD use of a
+       // syscall that can return EBADE, we assume EBADE really means authentication denied.
+#if defined(EBADE)
+       if (i == EBADE)
+          {eTxt = authenticationFailed;
+       } else
+#endif

Hoisted the code, also simplified the patch itself.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1916/review/1307607061@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1916#discussion_r1113187360", "url": "https://github.com/xrootd/xrootd/pull/1916#discussion_r1113187360", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1