Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
@osschar commented on this pull request.
Maybe someone else should check the XrdHttpReq stuff.
In src/XrdPfc/XrdPfcIOFile.cc:
> @@ -83,7 +83,7 @@ int IOFile::initCachedStat(const char* path)
int res = -1;
struct stat tmpStat;
- if (m_cache.GetOss()->Stat(path, &tmpStat) == XrdOssOK)
+ if (m_cache.GetOss()->Stat(GetFilename().c_str(), &tmpStat) == XrdOssOK)
path is file name of cinfo file ... and the stat here is mostly to check if it exists. This change stats the data file. Later error messages claim that cinfo file exits.
Size of file is set from the file-size in cinfo (expected, complete size).
Later you also reset all access times to 'now' ... I agree this is potentially better as cinfo file keeps changing with every access, even though the data could have been downloaded completely a long time ago.
We could leave atime as for the stat of cinfo (good approx for last access) and use info.GetCreationTime() for ctime and mtime (as you hinted to in a parallel communication).
Are there other fields in struct stat that you care about? It's not a problem to stat both, cinfo and data file -- I might change the arguments to this function to be a const std::string& ... or remove it altogether.
> }
-
+ else {
+ TRACEI(ALL, "GET returned no STAT information. Internal error?");
+ }
+
+ std::string responseHeader;
+ if (!m_digest_header.empty()) {
+ responseHeader = m_digest_header;
+ }
+ long one;
+ if (filemodtime && XrdOucEnv::Import("XRDPFC", one)) {
Are you sure you mean Import(...), not GetInt("XRDPFC")?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1