@bbockelm commented on this pull request.

> @@ -83,7 +83,7 @@ int IOFile::initCachedStat(const char* path)
    int res = -1;
    struct stat tmpStat;
 
-   if (m_cache.GetOss()->Stat(path, &tmpStat) == XrdOssOK)
+   if (m_cache.GetOss()->Stat(GetFilename().c_str(), &tmpStat) == XrdOssOK)

path is file name of cinfo file ... and the stat here is mostly to check if it exists. This change stats the data file. Later error messages claim that cinfo file exits.

Look at the indention on the error message. That references the failure to open the cinfo and remains correct.

Size of file is set from the file-size in cinfo (expected, complete size).

Yes, this remains unchanged.

Later you also reset all access times to 'now' ...

As you noticed later, this only occurs when the stat of the file or the open of the cinfo fails.

use info.GetCreationTime() for ctime and mtime

I'd actually prefer to separate these - mtime for the creation time (technically, this is all supposed to be immutable anyway, right? That means mtime really is the last possible modification) and ctime for the last update of the file.

I might change the arguments to this function to be a const std::string& ... or remove it altogether

Agreed. Will push that in the second version of the patch.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1919#discussion_r1114387277", "url": "https://github.com/xrootd/xrootd/pull/1919#discussion_r1114387277", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1