Print

Print

Is it normal that I get a 200 OK response though ?

Yeah -- this is a typical issue in HTTP where the HTTP status has to be sent before the body. So, if there's any I/O error, it's too late to change the response status code.

Currently, when an error happens mid-transfer, the server simply closes the TCP connection and the client reports something like "unexpected EOF". With this patch, if you ask for a status trailer, the client can get a useful error message (you might notice other PRs to improve error messages -- it's all related!).

This has to be opt-in, however, to prevent unexpecting clients from interpreting the early exit as a success as the response no longer generates TCP-level problems.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1912/c1440400451@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1912#issuecomment-1440400451", "url": "https://github.com/xrootd/xrootd/pull/1912#issuecomment-1440400451", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1