Hi David,

I would suggest using XrdSysRAtomic.hh whenever a relaxed atomic is
wanted. This is the only way to gaurantee that everyone uses that mutex in
relaxed mode. People forget as we have seen.

Andy

On Mon, 27 Feb 2023, David Smith wrote:

> Hi @simonmichal I'm only aware of a problem when the AsyncSocket is re-opened and reassigned to another poller.
>
> I just re-pushed a change to specify relaxed memory order on the std::atomic introduced by this patch; it took a while to convince myself this was ok (not that this makes any difference in generated code, in this case and on intel). I see we generally use relaxed order with std::atomics, and a comment in the XrdSys XrdSysRAtomic utility class contains a a suggestion to use a mutex to some cases, where a stronger guarantee is needed, explicit.
>
> --
> Reply to this email directly or view it on GitHub:
> https://github.com/xrootd/xrootd/pull/1935#issuecomment-1446050786
> You are receiving this because you are subscribed to this thread.
>
> Message ID: ***@***.***>

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1935#issuecomment-1446975285", "url": "https://github.com/xrootd/xrootd/pull/1935#issuecomment-1446975285", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1