@amadio commented on this pull request. > @@ -388,6 +413,23 @@ namespace XrdCl message.AdvanceCursor( bytesRead ); } + // Unmarchal to message body + Log *log = DefaultEnv::GetLog(); + XRootDStatus st = XRootDTransport::UnMarchalStatusMore( message ); + if( !st.IsOK() && st.code == errDataError ) + { + log->Error( XRootDTransportMsg, "[msg: 0x%x] %s", &message, + st.GetErrorMessage().c_str() ); + return st; + } + + if( !st.IsOK() ) Why do you need to test twice for `!st.IsOK()`? Could these two ifs not be joined into a single one? -- Reply to this email directly or view it on GitHub: https://github.com/xrootd/xrootd/pull/1854#pullrequestreview-1295811979 You are receiving this because you are subscribed to this thread. Message ID: <[log in to unmask]> ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1