Print

Print


@simonmichal commented on this pull request.



>  
-    //--------------------------------------------------------------------------
-    // Calculate the crc32c for the additional data
-    //--------------------------------------------------------------------------
-    ServerResponseBody_pgWrCSE *cse = (ServerResponseBody_pgWrCSE*)msg.GetBuffer( sizeof( ServerResponseV2 ) );
-    cse->cseCRC = ntohl( cse->cseCRC );
-    size_t length = rsp->status.bdy.dlen - sizeof( uint32_t );
-    void*  buffer = msg.GetBuffer( sizeof( ServerResponseV2 ) + sizeof( uint32_t ) );
-    uint32_t crcval = XrdOucCRC::Calc32C( buffer, length );
-
-    //--------------------------------------------------------------------------
-    // Do the integrity checks
-    //--------------------------------------------------------------------------
-    if( crcval != cse->cseCRC )
+    switch( reqType )

yes, exactly! right now `kXR_status` is used only for 'pgread'/'pgwrite' but in the future it could be used for other requests hence the switch statement.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1854#discussion_r1104708502
You are receiving this because you are subscribed to this thread.

Message ID: <[log in to unmask]>

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1