@matthewfeickert commented on this pull request.


In cmake/XRootDSummary.cmake:

> @@ -12,7 +12,7 @@ component_status( TESTS     BUILD_TESTS       CPPUNIT_FOUND )
 component_status( HTTP      BUILD_HTTP        OPENSSL_FOUND )
 component_status( TPC       BUILD_TPC         CURL_FOUND )
 component_status( MACAROONS BUILD_MACAROONS   MACAROONS_FOUND )
-component_status( PYTHON    BUILD_PYTHON      PYTHON_FOUND )
+component_status( PYTHON    BUILD_PYTHON      Python_FOUND )

@amadio I updated this from Python_FOUND to Python_Interpreter_FOUND AND Python_Development_FOUND as you suggested though note from https://cmake.org/cmake/help/v3.12/module/FindPython.html#result-variables that Python_FOUND is a boolean of if

System has the Python requested components

and so would be more robust to changes in the associated find_package command.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1906/review/1298924462@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1906#discussion_r1106737569", "url": "https://github.com/xrootd/xrootd/pull/1906#discussion_r1106737569", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1