@abh3 commented on this pull request.

I think the idea here is good, though somewhat limited as we can only get extended information from file objects not from generic methods. I suppose that's better than not but not completely satisfying. Of course, all of this is historic so at the moment it seems the best that can be done. All that said, in our meeting today we decided that this change really needs to go into R6 as it breaks ABI. Fortunately, that allows simplification because the whole XRDOSS_HASAERR checking can be eliminated. It's expected that the "extended information" is either implemented or returns nothing. So, code should simply check for extended error information. We are also worried on what the composite message would look like. Can you give some examples? If it becomes largely unreadable (think composite OpenSSL messages) this this patch would be of limited value. I know there is some concern about when R6 will be cut but it looks very likely to be in 2023. In the mean time this does open up the possibility to perhaps address the non-file based methods that return nothing more than an errno type message to make this feature complete.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1915/review/1310856564@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1915#pullrequestreview-1310856564", "url": "https://github.com/xrootd/xrootd/pull/1915#pullrequestreview-1310856564", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1