Print

Print

I wondering if we shouldn't guard the following block:

%check
 cd xrootd/build
 %if %{use_cmake3}
 ctest3 --output-on-failure
 %else
 ctest --output-on-failure
 %endif

with %if %{?_with_tests:1}%{!?_with_tests:0}, meaning enforce the check only if we are building with _with_tests flag.

Otherwise looks good :-)

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1965/c1473685031@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1965#issuecomment-1473685031", "url": "https://github.com/xrootd/xrootd/pull/1965#issuecomment-1473685031", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1