LISTSERV 16.5 - XROOTD-DEV Archives

Hi @abh3 , 

This PR to address the issue https://github.com/xrootd/xrootd/issues/1967

It looks to me like the shutdown of the TLS /SSLconnection via `SSL_shutdown()` is not as well protected as the way it is done in the XrdTlsSocket code: https://github.com/xrootd/xrootd/blob/master/src/XrdTls/XrdTlsSocket.cc#L753

For example, according to the documentation:
&gt; Note that SSL_shutdown() must not be called if a previous fatal error has occurred on a connection i.e. if SSL_get_error() has returned SSL_ERROR_SYSCALL or SSL_ERROR_SSL.

Is this a problem that needs to be addressed?

Thanks in advance for your review
You can view, comment on, or merge this pull request online at:

  https://github.com/xrootd/xrootd/pull/1968

-- Commit Summary --

  * [XrdHttp] Proper handling of SSL_Shutdown() return code

-- File Changes --

    M src/XrdHttp/XrdHttpProtocol.cc (15)

-- Patch Links --

https://github.com/xrootd/xrootd/pull/1968.patch
https://github.com/xrootd/xrootd/pull/1968.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1968
You are receiving this because you are subscribed to this thread.

Message ID: &lt;[log in to unmask]&gt;

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1