LISTSERV 16.5 - XROOTD-DEV Archives

This PR to address the issue #1967

It looks to me like the shutdown of the TLS /SSLconnection via SSL_shutdown() is not as well protected as the way it is done in the XrdTlsSocket code: https://github.com/xrootd/xrootd/blob/master/src/XrdTls/XrdTlsSocket.cc#L753

For example, according to the documentation:

Note that SSL_shutdown() must not be called if a previous fatal error has occurred on a connection i.e. if SSL_get_error() has returned SSL_ERROR_SYSCALL or SSL_ERROR_SSL.

Is this a problem that needs to be addressed?

Thanks in advance for your review

You can view, comment on, or merge this pull request online at:

https://github.com/xrootd/xrootd/pull/1968

Commit Summary

84ce44b [XrdHttp] Proper handling of SSL_Shutdown() return code

File Changes

(1 file)

M src/XrdHttp/XrdHttpProtocol.cc (15)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1968", "url": "https://github.com/xrootd/xrootd/pull/1968", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1