@theanalyst commented on this pull request.
> @@ -1759,10 +1759,17 @@ void XrdHttpProtocol::Cleanup() {
if (ssl) {
-
- if (SSL_shutdown(ssl) != 1) {
- TRACE(ALL, " SSL_shutdown failed");
- ERR_print_errors(sslbio_err);
+ int ret = SSL_shutdown(ssl);
+ if (ret != 1) {
+ if(ret == 0) {
+ //https://www.openssl.org/docs/man1.0.2/man3/SSL_shutdown.html
+ //Call again SSL_shutdown
+ ret = SSL_shutdown(ssl);
> I was thinking about calling `SSL_get_error`, as recommended in the docs.
The current docs only mention this function as a switch statement for a few functions (not including ssl_shutdown), not sure whether the doc. is reflective of reality tho :/
"SSL_get_error() returns a result code (suitable for the C "switch" statement) for a preceding call to SSL_connect(), SSL_accept(), SSL_do_handshake(), SSL_read(), SSL_peek(), or SSL_write() on ssl."
--
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1968#discussion_r1142384726
You are receiving this because you are subscribed to this thread.
Message ID: <[log in to unmask]>
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
