@amadio commented on this pull request.
> @@ -730,16 +730,26 @@ time_t XrdCryptosslASN1toUTC(const ASN1_TIME *tsn1)
&(ltm.tm_year), &(ltm.tm_mon), &(ltm.tm_mday),
&(ltm.tm_hour), &(ltm.tm_min), &(ltm.tm_sec),
&zz) != 7) || (zz != 'Z')) {
- return -1;
+ // Try GeneralizedTime
+ if ((sscanf((const char *)(tsn1->data),
+ "%04d%02d%02d%02d%02d%02d%c",
+ &(ltm.tm_year), &(ltm.tm_mon), &(ltm.tm_mday),
+ &(ltm.tm_hour), &(ltm.tm_min), &(ltm.tm_sec),
+ &zz) != 7) || (zz != 'Z')) {
+ return -1;
+ }
Hi @gganis, I wonder if we shouldn't also handle the case with a timezone if we are touching this code (i.e. something like the third example [here](https://en.wikipedia.org/wiki/GeneralizedTime))? What do you think?
--
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1970#pullrequestreview-1350394056
You are receiving this because you are subscribed to this thread.
Message ID: <[log in to unmask]>
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
