Print

Print

@amadio commented on this pull request.

In src/XrdCrypto/XrdCryptosslAux.cc:

>        ltm.tm_year += 100;
+   // In case GeneralizedTime is used
+   if (ltm.tm_year > 2000)
+      ltm.tm_year -= 1900;

I think we need ltm.tm_year > 1900 here instead of ltm.tm_year > 2000, otherwise I see wrong dates (i.e. with year >3600) being generated.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1970/review/1350662676@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1970#pullrequestreview-1350662676", "url": "https://github.com/xrootd/xrootd/pull/1970#pullrequestreview-1350662676", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1