Print

Print

@amadio So, I had two comments on corrections needed (i.e. sysheaders before local headers and non-directory qualified includes). I suggested correcting the sysheader problem but ignoring the include problem as it was endemic to this whole package. Then I realized that so was the sysheader problem. So, perhaps asking @ccaffy to correct the sysheader problem in files he touched is not a good idea and instead we should do a global change using another pr. What do you think?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: <xrootd/xrootd/pull/1950/c1478836469@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1950#issuecomment-1478836469", "url": "https://github.com/xrootd/xrootd/pull/1950#issuecomment-1478836469", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1