@amadio commented on this pull request.


In tests/XrdHttpTests/XrdHttpTests.cc:

> @@ -0,0 +1,167 @@
+#undef NDEBUG

I think it's not necessary to split into another pull request. Just a separate commit within this pull request is fine. I just want to cherry-pick just the fix for the patch release, and leave the tests just on master, since it depends on GoogleTest.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: <xrootd/xrootd/pull/1950/review/1351928809@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1950#discussion_r1144375251", "url": "https://github.com/xrootd/xrootd/pull/1950#discussion_r1144375251", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1