 |
 |
Yes, let's go for a global change for the header ordering, it's out of scope for this pull request. However, I'd argue that we should put our headers first, to ensure that we are not missing any includes (e.g. using `std::cout` without including `<iostream>` in the header, but getting it only as side effect of previous includes). Also, if we use `""` instead of `<>` when including, then I think we need to leave the base directory out. So, for example, we do either `#include <XrdHttp/XrdHttpReq.hh>` or `#include "XrdHttpReq.hh"` in `src/XrdHttp/XrdHttpReq.cc`, but we will handle this later in another pull request. -- Reply to this email directly or view it on GitHub: https://github.com/xrootd/xrootd/pull/1950#issuecomment-1479087955 You are receiving this because you commented. Message ID: <[log in to unmask]> ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1