@ccaffy commented on this pull request.


In src/XrdHttp/README-CKSUM.md:

> @@ -0,0 +1,15 @@
+In the case XrdHttp has been configured, it is important that the configuration contains at least one digest algorithm registered in the IANA database: https://www.iana.org/assignments/http-dig-alg/http-dig-alg.xhtml
+Otherwise the user will get a 403 error for each checksum request they will do.
+
+Here is a table summarizing the IANA-compliant checksum names:
+
+| Digest algorithm | HTTP digest | Will be base64 encoded |
+|------------------|-------------|------------------------|
+| md5              | md5         | true                   |
+| adler32          | adler32     | false                  |
+| sha1             | sha         | true                   |
+| sha256           | sha-256     | true                   |
+| sha512           | sha-512     | true                   |
+| cksum            | UNIXcksum   | false                  |

@bbockelm thanks for your reply. What you said about the xrootd-hdfs plugins triggers some questioning on my side: I wanted to be nice with server administrator allowing them to set, for example, sha512 or sha-512 for configuring a sha-512 algorithm. This would not have worked before my modification, see this function here: https://github.com/xrootd/xrootd/blob/master/src/XrdHttp/XrdHttpReq.cc#L134

If there are other plugins that can be used to compute checksums, could my new implementation cause problems?


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: <xrootd/xrootd/pull/1950/review/1352060333@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1950#discussion_r1144462709", "url": "https://github.com/xrootd/xrootd/pull/1950#discussion_r1144462709", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1