@ccaffy commented on this pull request.


In src/XrdHttp/XrdHttpReq.cc:

>   */
-void XrdHttpReq::selectChecksum(const std::string &userDigest, std::string & selectedChecksum) {
-    char * configChecksumList = XrdHttpProtocol::xrd_cslist;
-    selectedChecksum = "unknown";
+void XrdHttpReq::selectXRootDChecksum(const char * configChecksumList, const std::string &userDigest, std::string & xrootdSelectedChecksum) {
+    xrootdSelectedChecksum = "unknown";
     if(configChecksumList != nullptr) {

That's correct indeed, I wanted to be extra sure that there will be a value, but it is at the end not needed :)


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1950/review/1334364007@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1950#discussion_r1132083056", "url": "https://github.com/xrootd/xrootd/pull/1950#discussion_r1132083056", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1