Hello. To fix #1993, a missing specialisation for PgRead is added to ProxyPrefixFile (in the XrdClProxyPlugin).
This patch also adds a few other missing method overrides. i.e.
(i) Added missing override of PgRead, Write (1 already present, 2 other overloads added), PgWrite, VectorWrite, WriteV.
(ii) Did not add override for Read(6 argument version); present in the base (XrdCl::FilePlugIn) but not called from XrdClFile. Method appears unused, possibly could be removed in release 6. (The XrdClPlugInInterface.hh is public so can't change before then).
(iii) Likely we're missing ReadV, but this is not present in the base. The ReadV() interface was added after release of xrootd5, so maybe ReadV can be added to XrdClPlugInInterface for release 6.
(iv) Added override specifier on declarator of overridden methods in ProxyPrefixFile.hh. (c++11)
You can view, comment on, or merge this pull request online at:
https://github.com/xrootd/xrootd/pull/1994
-- Commit Summary --
* [XrdApps] Let XrdClProxyPlugin work with PgRead, adding some missing methods
-- File Changes --
M src/XrdApps/XrdClProxyPlugin/ProxyPrefixFile.hh (101)
-- Patch Links --
https://github.com/xrootd/xrootd/pull/1994.patch
https://github.com/xrootd/xrootd/pull/1994.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1994
You are receiving this because you are subscribed to this thread.
Message ID: <[log in to unmask]>
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
