@abh3 requested changes on this pull request.

This isn't thread-safe. Notice that syncwait is being changed without holding the file lock while another thread holds the file lock to safely inspect it. The solution here is to set syncwait to null immediately after it is posted as the file lock is still being held there. Logically, the semaphore should only be posted once as it can have no more than one thread waiting on it.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1996#pullrequestreview-1380294679", "url": "https://github.com/xrootd/xrootd/pull/1996#pullrequestreview-1380294679", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1