Print

Print

@abh3 commented on this pull request.

OK, I do know Clang wants override but why only this set of methods. We haven't used override (though we should) in most other classes simply because that code predates "override". Also one other question about an oddity.

In src/XrdPosix/XrdPosixAdmin.cc:

> @@ -51,7 +51,7 @@ XrdCl::URL *XrdPosixAdmin::FanOut(int &num)
    XrdCl::URL                    *uVec;
    XrdNetAddr netLoc;
    const char *hName;
-   unsigned int i;
+   unsigned long i;

Why does Clang need this to be a long?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1997/review/1384594819@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1997#pullrequestreview-1384594819", "url": "https://github.com/xrootd/xrootd/pull/1997#pullrequestreview-1384594819", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1