Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
@abh3 commented on this pull request.
OK, I have looked at this and I cannot say I am happy. This is not what we have traditionally doe visive the architecture. The approach here is rather invasive as it tries to force the whole http header protocol all the way through the end-point code. That really is not what we want to do. In general, we have always promoted headers to cgi elements. In this case, one would need to promote header sub-elements to cgi elements. We then do not pollute the code with specific syntax requirements, Additionally, the protocol gets to choose what actually gets exposed and it's all done in a way that is transparent. I know you spent a lot of work here (obviously) but the approach is really not the way to go as it really muddles the code.
I also see that you better structured the http state machine. That was a good thing. Unfortunately, it's totally tied up with this feature patch. They really should be sperate changes. Could we start with that (i.e. fixing the http state machine)?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1