 |
 |
OK, I do know Clang wants override but why only this set of methods. We haven't used override (though we should) in most other classes simply because that code predates "override". Also one other question about an oddity.
GCC doesn't warn about it, but adding override informs the compiler about what we want to do and if the overriden/overriding method's signature is wrong or if the method we are overriding is not virtual, it will fail to compile. The commit adds the override specifier in the few places where it was expected but was not there yet. The errors shown in this example in cppreference show well the kind of checks we get by adding the override specifier.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1