Print

Print


> OK, all I see is using std removals. I also see that implicit use of std was already corrected in a previous pull request. So, it looks OK. I was wondering why did we eschew using declaration notation to fix this?

This is the same pull request, but I separated the parts fixing implicit usage of std and pushed it, so all that's left here is the removal of `using namespace std;` from the code.

As for using declarations, in one of our meetings when we discussed this, we decided to keep using `std::` in code rather than declarations for the sake of consistency. Since we cannot use declarations in our headers, rather than have a separate policy for headers and sources, we decided to go with using `std::` everywhere.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1933#issuecomment-1511354058
You are receiving this because you commented.

Message ID: <[log in to unmask]>

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1