Well, I willlook at this more closely but simply looking at the small code
segment it's quite obvious that he logic is completely different between
the two. Si, I say caution!
On Mon, 17 Apr 2023, Guilherme Amadio wrote:
> @amadio commented on this pull request.
>
>
>
>> else {i -= XRD_FTABSIZE;
> if (XTab && i < XTnum) fP = &XTab[i];
> else fP = 0;
> + i += XRD_FTABSIZE;
> }
>
> ```suggestion
> else {int ix = i - XRD_FTABSIZE;
> if (XTab && ix < XTnum) fP = &XTab[ix];
> else fP = 0;
> }
> ```
>
> --
> Reply to this email directly or view it on GitHub:
> https://github.com/xrootd/xrootd/pull/1998#pullrequestreview-1387633624
> You are receiving this because you are subscribed to this thread.
>
> Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Message ID: <xrootd/xrootd/pull/1998/c1511541067@github.com>
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/xrootd/xrootd/pull/1998#issuecomment-1511541067",
"url": "https://github.com/xrootd/xrootd/pull/1998#issuecomment-1511541067",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1