Print

Print

Yes, I do remember we decided on that. I was just having second thoughts given what other projects do. For instance, in LSST common std symbols are declared in the cc file in which they are used (e.g. std::vector, std::string, etc) to shorten the code. The idea here is that these names have now become effectively baked into the compiler. So, that was all I was going after to see what you thought about it.

BTW if you are waiting for Michal to do a review you may never stop waiting. I think the rest of the month he's using up his vacation. So, you may want to remove him as a reviewer and merge this.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: <xrootd/xrootd/pull/1933/c1511642738@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1933#issuecomment-1511642738", "url": "https://github.com/xrootd/xrootd/pull/1933#issuecomment-1511642738", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1