@amadio commented on this pull request.

In src/XrdCl/XrdClAsyncSocketHandler.hh:

> @@ -149,67 +149,67 @@ namespace XrdCl
       //------------------------------------------------------------------------
       // Connect returned
       //------------------------------------------------------------------------
-      virtual void OnConnectionReturn();
+      virtual XRootDStatus OnConnectionReturn();

Andy suggests to add XRD_WARN_UNUSED_RESULT to these to ensure we are not ignoring any of the status being returned in other places.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1946#pullrequestreview-1392622492", "url": "https://github.com/xrootd/xrootd/pull/1946#pullrequestreview-1392622492", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1