@smithdh commented on this pull request.

In src/XrdCl/XrdClAsyncSocketHandler.cc:

> @@ -220,11 +221,11 @@ namespace XrdCl
     {
       pLastActivity = time(0);
       if( unlikely( pTlsHandShakeOngoing ) )
-        OnTLSHandShake();
+        st = OnTLSHandShake();

For the call to OnTLSHandShake() below (concerning writing) the flow doesn't do anything after the call (i.e. it returns from AsyncSocketHandler::Event(), which is what I was going to do for the error case) so I didn't add the check. But it's a good point this looks quite strange perhaps it's a trap for future modifications, e.g. if something is added it might also get executed during the error condition.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1946#discussion_r1172558519", "url": "https://github.com/xrootd/xrootd/pull/1946#discussion_r1172558519", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1