I've pushed changes:
- changed return type to bool
- refactored previous read/write parts of AsyncSocketHandler::Event() into two methods EventRead() EventWrite() in order to remove the previous large number of 'st = Func();' style assignments.
- Added reset of pTlsHandShakeOngoing, pHSWaitStarted, pHSWaitSeconds=0 in AsyncSocketHandler::Connect(). This is because I made a change of logic in AsyncSocketHandler::CheckHSWait(): e.g. previously on wait-time elapse, pHSWaitSeconds was always set to 0 even if the previous SendHSMsg() caused a failure. The reset was never strictly safe (since perhaps the object is deleted or reused), however simply returning after the failure added another way for pHSWaitSeconds to be non-zero after a re-connect (I believe there were already other ways this can happen too). As there are paths where several members that track connection state are not reset on re-connect I took the opportunity to reset those in Connect(); although I don't believe this is involved in any reported problem that I've look into.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1946/c1525761335@github.com>
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/xrootd/xrootd/pull/1946#issuecomment-1525761335",
"url": "https://github.com/xrootd/xrootd/pull/1946#issuecomment-1525761335",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1