The Ceph plugin used to be part of the main repository until 83f38cb, which created a submodule for it, I believe upon request by the main user of XrdCeph from RAL (@simonmichal can clarify here).

Having it as a separate repository does not help us much, since we need to tag xrootd-ceph when we tag xrootd, but for several versions in a row, there were no changes to xrootd-ceph, so the extra steps during the release are the only visible change. It complicates the release procedure for xrootd as a whole, so my thought was that if we keep the ability to build it separately against an existing installation of XRootD, it would be fine to merge it back into the main repository and use conditionals in the spec file to only build it where it is needed.

The other reason is that having it as a git submodule means that in the CI system submodules need to be cloned later, and we have to keep adding workarounds like https://github.com/xrootd/xrootd/blob/master/.github/workflows/build.yml#L232-L233 and 4897bfa so that git doesn't get confused with permissions (usually when CI runs in a container) and fails the build.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/2008/c1549154916@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/2008#issuecomment-1549154916", "url": "https://github.com/xrootd/xrootd/pull/2008#issuecomment-1549154916", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1