The latest updates to glibc headers adds __nonnull to the fclose()

Declaration in old version:

extern int fclose (FILE *__stream);

Declaration in new version:

extern int fclose (FILE *__stream) __nonnull ((1));

This change causes a compilation error in xrootd:

/builddir/build/BUILD/xrootd-5.5.5/src/XrdTls/XrdTlsTempCA.cc:54:48: error: ignoring attributes on template argument 'int (*)(FILE*)' [-Werror=ignored-attributes]
   54 | typedef std::unique_ptr<FILE, decltype(&fclose)> file_smart_ptr;
      |                                                ^

This commit rewrites the code so the error is not triggered.


You can view, comment on, or merge this pull request online at:

  https://github.com/xrootd/xrootd/pull/2012

Commit Summary

File Changes

(1 file)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/2012@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/2012", "url": "https://github.com/xrootd/xrootd/pull/2012", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1