@amadio commented on this pull request.

In src/XrdTls/XrdTlsTempCA.cc:

> @@ -50,8 +50,9 @@
 #include <atomic>
 
 namespace {
-    
-typedef std::unique_ptr<FILE, decltype(&fclose)> file_smart_ptr;
+
+static void FClose(FILE *f) {fclose(f);}

Is adding this really necessary? I wonder if just adjusting the typedef to use void(*)(FILE*) instead of decltype(&fclose) is already enough.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/2012/review/1435931703@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/2012#pullrequestreview-1435931703", "url": "https://github.com/xrootd/xrootd/pull/2012#pullrequestreview-1435931703", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1