@abh3 requested changes on this pull request.
> @@ -1391,6 +1391,10 @@ static int mapError(int rc)
case ETIMEDOUT: return kXR_ReqTimedOut;
case EBADF: return kXR_FileNotOpen;
case ECANCELED: return kXR_Cancelled;
+ // In the case one tries to delete a non-empty directory
+ // we have decided that until the next major release
+ // the kXR_ItExists flag will be returned
+ case ENOTEMPTY: return kXR_ItExists;
What should happen here is that this case needs to be put ahead if the kXR_ItExists case as a falthrough. That is
using [[fallthrough]]; to indicate that the fallthrough is correct.
--
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/2016#pullrequestreview-1445619282
You are receiving this because you are subscribed to this thread.
Message ID: <[log in to unmask]>
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
