Yes, it's a fallthrough case which makes it much more obvious what is
happening. Don't forget to specify [[falthrough]]

On Fri, 26 May 2023, ccaffy wrote:

> @ccaffy commented on this pull request.
>
>
>
>> @@ -1391,6 +1391,10 @@ static int mapError(int rc)
> case ETIMEDOUT: return kXR_ReqTimedOut;
> case EBADF: return kXR_FileNotOpen;
> case ECANCELED: return kXR_Cancelled;
> + // In the case one tries to delete a non-empty directory
> + // we have decided that until the next major release
> + // the kXR_ItExists flag will be returned
> + case ENOTEMPTY: return kXR_ItExists;
>
> I do not understand :thinking: Is it a fallthrough case? I just return kXR_ItExists when the errno code is ENOTEMPTY. Each switch case has a return value, so there's no need for a `[[fallthrough]];` attribute, isn't it?
>
> --
> Reply to this email directly or view it on GitHub:
> https://github.com/xrootd/xrootd/pull/2016#discussion_r1206499288
> You are receiving this because your review was requested.
>
> Message ID: ***@***.***>

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/2016#issuecomment-1565219296", "url": "https://github.com/xrootd/xrootd/pull/2016#issuecomment-1565219296", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1