LISTSERV 16.5 - XROOTD-DEV Archives

@abh3 requested changes on this pull request.

I don't think I really explained myself here.

> @@ -1391,6 +1391,11 @@ static int mapError(int rc)
            case ETIMEDOUT:     return kXR_ReqTimedOut;
            case EBADF:         return kXR_FileNotOpen;
            case ECANCELED:     return kXR_Cancelled;
+           // In the case one tries to delete a non-empty directory

Well, I think we have miscommunicated. What I really meant was the following:

case ENOTEMPTY: [[fallthrough]]
case EEXIST: return kXR_ItExists;

So the ENOTEMPTY case is placed right before the EEXIST case. The point being is that one is merging both return codes into one XRootD error. There is no separate return. I know I am being a pain here, sigh. Anyway, at some point gcc will complain about the misplaced [[fal;through]].

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/2016#pullrequestreview-1450360506", "url": "https://github.com/xrootd/xrootd/pull/2016#pullrequestreview-1450360506", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1