@amadio commented on this pull request.
> @@ -1370,7 +1370,11 @@ static int mapError(int rc)
case ENOTBLK: return kXR_NotFile;
case ENOTSUP: return kXR_Unsupported;
case EISDIR: return kXR_isDirectory;
- case EEXIST: return kXR_ItExists;
+ case EEXIST: [[fallthrough]];
+ // In the case one tries to delete a non-empty directory
+ // we have decided that until the next major release
+ // the kXR_ItExists flag will be returned
+ case ENOTEMPTY: return kXR_ItExists;
This is really just nitpicking, so feel free to ignore, but I'd put the `return kXR_ItExists;` on `case EEXIST`, and put `case ENOTEMPTY` as the fall through.
--
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/2016#pullrequestreview-1450438142
You are receiving this because you are subscribed to this thread.
Message ID: <[log in to unmask]>
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
