@abh3 approved this pull request.

One additional missing spec. See commens. Otherwise fine.

> @@ -0,0 +1,98 @@
+#!/usr/bin/env bash
+
+: ${XRDCP:=$(command -v xrdcp)}
+: ${XRDFS:=$(command -v xrdfs)}
+: ${CRC32C:=$(command -v xrdcrc32c)}
+: ${ADLER32:=$(command -v xrdadler32)}
+: ${OPENSSL:=$(command -v openssl)}
+: ${HOST:=root://localhost:${PORT:-1094}}
+
+for PROG in ${XRDCP} ${XRDFS} ${OPENSSL}; do

Add new programs

In tests/XRootD/xrootd.cfg:

> @@ -0,0 +1,8 @@
+# This minimal configuration file starts a standalone server
+# that exports the data directory as / without authentication.
+
+all.export /
+all.sitename XRootD
+oss.localroot @CMAKE_CURRENT_BINARY_DIR@/data
+xrd.port @XRD_TEST_PORT@
+xrootd.chksum adler32

crc32c is missing

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/2044#pullrequestreview-1486184989", "url": "https://github.com/xrootd/xrootd/pull/2044#pullrequestreview-1486184989", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1