Print

Print

@matthewfeickert commented on this pull request.

In bindings/python/setup.py:

> @@ -0,0 +1,143 @@
+import os
+import platform
+import subprocess
+import sys
+
+from setuptools import setup, Extension
+from setuptools.command.build_ext import build_ext
+from subprocess import check_call, check_output
+from distutils.spawn import find_executable

Please don't put distutils back in. This is deprecated behavior.

In general it seems like this is a lot of extra work to use setuptools when scikit-build-core already exists. https://scikit-build-core.readthedocs.io/

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/2025/review/1462955670@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/2025#pullrequestreview-1462955670", "url": "https://github.com/xrootd/xrootd/pull/2025#pullrequestreview-1462955670", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1