@amadio commented on this pull request.

In src/XrdCrypto/XrdCryptosslCipher.hh:

> @@ -39,8 +39,6 @@
 #include <openssl/evp.h>
 #include <openssl/dh.h>
 
-#define kDHMINBITS 512

This was needed by the commented out code, so maybe move it there. Otherwise, if/when we uncomment the code, it will fail to compile.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/2026/review/1467029570@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/2026#pullrequestreview-1467029570", "url": "https://github.com/xrootd/xrootd/pull/2026#pullrequestreview-1467029570", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1