 |
 |
@abh3 commented on this pull request.
Other than a code reduction comment I don't see anything inherently wrong here assuming all the frees are appropriate. Let's see what @gganis has to say.
In src/XrdCrypto/XrdCryptosslgsiAux.cc:
> @@ -900,9 +950,45 @@ int XrdCryptosslX509SignProxyReq(XrdCryptoX509 *xcpi, XrdCryptoRSA *kcpi,
PRINT("inconsistent key loaded");
return -kErrPX_BadEECkey;
}
+
+ // These will be assigned dynamically allocated ssl structures later.
+ // An RAII style guard is used to free them on exit from this method.
+ EVP_PKEY *ekpi = 0;
+ X509 *xpo = 0;
+ X509_EXTENSION *ext = 0;
+ PROXY_CERT_INFO_EXTENSION *pci = 0;
+ STACK_OF(X509_EXTENSION) *xrisk = 0;
+
+ class sslGuard {
This definition of sslGaurd is almost identical to the previous version. It should be trivial to define a superset of sslGaurd and only have one definition placed at file level and used where need.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1