@bbockelm commented on this pull request. > + X509_REQ *xro = 0; + PROXY_CERT_INFO_EXTENSION *pci = 0; + STACK_OF(X509_EXTENSION) *esk = 0; + + class sslGuard { + public: + sslGuard(EVP_PKEY *&epk, X509_EXTENSION *&xext, X509_NAME *&xname, + X509_REQ *&xreq, PROXY_CERT_INFO_EXTENSION *&pci, + STACK_OF(X509_EXTENSION) *&ske) : + epk_(epk), xext_(xext), xname_(xname), xreq_(xreq), pci_(pci), + ske_(ske) { } + + ~sslGuard() { +#if OPENSSL_VERSION_NUMBER >= 0x10000000L + sk_X509_EXTENSION_pop_free(ske_, X509_EXTENSION_free); +#else /* OPENSSL */ Can we drop support for pre-OpenSSL 1.0? That would mean we drop support for RHEL5 (which seems OK). -- Reply to this email directly or view it on GitHub: https://github.com/xrootd/xrootd/pull/2029#pullrequestreview-1471064042 You are receiving this because you are subscribed to this thread. Message ID: <[log in to unmask]> ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1