@bbockelm commented on this pull request.
> @@ -656,17 +656,61 @@ int XrdCryptosslX509CreateProxyReq(XrdCryptoX509 *xcpi,
PRINT("EEC certificate has expired");
return -kErrPX_ExpiredEEC;
}
+
+ // These will be assigned dynamically allocated ssl structures later.
+ // An RAII style guard is used to free them on exit from this method.
+ EVP_PKEY *ekro = 0;
If you don't want the bother of an entire class, you could do something like:
```
std::unique_ptr<EVP_PKEY, decltype(EVP_PKEY_free)> ekro(nullptr, &EVP_PKEY_free)
```
Type definition is uglier but maybe clearer to some?
--
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/2029#pullrequestreview-1471064851
You are receiving this because you are subscribed to this thread.
Message ID: <[log in to unmask]>
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
