Thank you for the comments; I've aimed to take those on; changed to using std::unique_ptr (with a type alias to try to make it clearer); which means no repetition of the previous 'sslGuard' class. Also added a return code check on a call of ExportPrivate(). I didn't remove the pre-openssl-1.0-case call yet, although probably we don't need it.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/2029/c1584651119@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/2029#issuecomment-1584651119", "url": "https://github.com/xrootd/xrootd/pull/2029#issuecomment-1584651119", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1