Print

Print


@amadio requested changes on this pull request.


In docker/build/Dockerfile.unprivileged.alma9:

> @@ -0,0 +1,133 @@
+# This dockerfile assumes that you're passing the binary with its corresponding arguments to run it.

A container that can be run this way is nice to have, but I think it's better to modify our current container to allow it rather than create a different install procedure, as this one is a lot more complicated than what we currently have, and can become out of date, as dependencies, build options, etc, are hard-coded. For example, if we remove ENABLE_SCITOKENS option in the future, it would require changing this file. I also think that it is already possible to do this with our current container if you pass the full command line with xrootd ... when running the container, no?


In docker/build/Dockerfile.unprivileged.alma9:

> +RUN dnf install -y \
+    openssl \
+    libuuid \
+    libxml2 \
+    python3 \
+    zlib \
+    tinyxml \
+    davix-libs
+
+RUN if [ "${ENABLE_KRB5}" =  "ON" ]; then dnf install -y krb5-libs; fi
+RUN if [ "${ENABLE_HTTP}" = "ON" ]; then dnf install -y libcurl-minimal; fi
+RUN if [ "${ENABLE_FUSE}" = "ON" ]; then dnf install -y fuse-libs; fi
+RUN if [ "${ENABLE_PYTHON}" = "ON" ]; then dnf install -y python3; fi
+RUN if [ "${ENABLE_SCITOKENS}" = "ON" ]; then dnf install -y scitokens-cpp; fi
+RUN if [ "${ENABLE_MACAROONS}" = "ON" ]; then dnf install -y libmacaroons; fi
+RUN if [ "${ENABLE_XRDCEPH}" = "ON" ]; then dnf install -y librados2 libradosstriper1; fi

These create many unnecessary layers in the final container and will cause many rebuilds when one of the layers change.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/2066/review/1559301633@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/2066#pullrequestreview-1559301633", "url": "https://github.com/xrootd/xrootd/pull/2066#pullrequestreview-1559301633", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1