Print

Print

@amadio commented on this pull request.

In src/XrdHttp/XrdHttpReq.cc:

> @@ -1115,6 +1115,11 @@ int XrdHttpReq::ProcessHTTPReq() {
 
           }
       
+      // The reqstate parameter basically moves us through a simple state machine.
+      // - 0: Perform a stat on the resource
+      // - 1: Perform a checksum request on the resource (only if requested in header; otherwise skipped)
+      // - 2: Perform an open request (dirlist as appropriate).
+      // - 3+: Reads from file; if at end, perform a close.

I suppose reads are a lot more common than stats, checksums, or open requests, so maybe it's worth having that as if (reqstate >= 3) do_read(); else switch(reqstate) ...?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/2072/review/1582918481@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/2072#pullrequestreview-1582918481", "url": "https://github.com/xrootd/xrootd/pull/2072#pullrequestreview-1582918481", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1