@amadio commented on this pull request.
> m_log.Emsg("CRLset", "Failed to write out CRL", fname.c_str());
fflush(outputfp.get());
return false;
+ }
}
It seems to me that you could declare the vector `m_crls_critical_extension` before the `for` loop, then process it here, no? You can then pass a reference to it to `processCRLWithCriticalExt` and avoid adding a member to the class.
--
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/2073#pullrequestreview-1586830284
You are receiving this because you are subscribed to this thread.
Message ID: <[log in to unmask]>
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
