Print

Print

@amadio commented on this pull request.

In src/XrdTls/XrdTlsTempCA.cc:

>              m_log.Emsg("CRLset", "Failed to write out CRL", fname.c_str());
             fflush(outputfp.get());
             return false;
+          }
         }

It seems to me that you could declare the vector m_crls_critical_extension before the for loop, then process it here, no? You can then pass a reference to it to processCRLWithCriticalExt and avoid adding a member to the class.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/2073/review/1586830284@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/2073#pullrequestreview-1586830284", "url": "https://github.com/xrootd/xrootd/pull/2073#pullrequestreview-1586830284", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1