Thanks Cedric!
On Tue, 22 Aug 2023, ccaffy wrote:
> @ccaffy commented on this pull request.
>
>
>
>> @@ -217,6 +234,26 @@ bool CRLSet::atLeastOneValidCRLFound() const {
> return m_atLeastOneValidCRLFound;
> }
>
> +bool CRLSet::processCRLWithCriticalExt() {
> + // Don't open the output file if not necessary
> + if(!m_crls_critical_extension.empty()) {
> + file_smart_ptr outputfp(fdopen(dup(m_output_fd), "w"), &fclose);
>
> I actually did it as it did not take a lot of time. I will submit a different PR once this one has been approved and merged to master
>
> --
> Reply to this email directly or view it on GitHub:
> https://github.com/xrootd/xrootd/pull/2073#discussion_r1301332030
> You are receiving this because you were mentioned.
>
> Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Message ID: <xrootd/xrootd/pull/2073/c1688568196@github.com>
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/xrootd/xrootd/pull/2073#issuecomment-1688568196",
"url": "https://github.com/xrootd/xrootd/pull/2073#issuecomment-1688568196",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
